otatools out path seems to have changed relative to grapheneos

otatools out path seems to have changed relative to grapheneos

Does this affect signing?

It affects the entire build, since the android derivation is failing now.

It affects the entire build, since the android derivation is failing now.

I am still able to build lineageos images with this bump

Huh, interesting. Brief summary of what I have been up to: I've been trying to build for FP4, but the output path of otatools.zip had changed again, even though the build/make/tools/otatools_package/Android.bp hadn't changed at all. It's now located at $ANDROID_PRODUCT_OUT/otatools.zip again, like it was when otatools.zip still was a Make target instead of a Soong rule (and the build is failing now, as a consequence)

I didn't feel comfortable with doing guesswork as to which versions/devices are affected by this, so I spent some time digging into Soong internals (which was significantly complicated by the high degree of complexity of Soong and the lack of docs available to me). So far, I've found out that since the switch to Soong, otatools.zip is being copied over to the $ANDROID_PRODUCT_OUT dir by the Make rules generated in build/make/packaging/distdir.mk. The list of files to be copied over comes from the DIST_SRC_DST_PAIRS make variable, which is defined in out/soong/kati_packaging-<devicename>/dist.mk, which in turn is generated by Soong in build/soong/android/androidmk.go based on the dist parameter of the Soong module in question (otatools-package in this case).

The Make targets for copying over the files to DIST_DIR aka $ANDROID_PRODUCT_OUT however are only generated if the DIST make variable is set. And right now, I'm having trouble figuring out why it is set on LineageOS but not on GrapheneOS. Any help to get this sorted out properly would be appreciated :D